fix: only bump file mtime when document transitions from modified to saved#5699
Closed
juliusknorr wants to merge 1 commit into
Closed
fix: only bump file mtime when document transitions from modified to saved#5699juliusknorr wants to merge 1 commit into
juliusknorr wants to merge 1 commit into
Conversation
…saved Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Julius Knorr <jus@bitgrid.net>
Member
Author
|
Actually this is not needed, Collabora seems to sent lots of messages on unchanged odp files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a file (e.g. a presentation) and closing it without making any edits was bumping the modified date in the Files listing to "seconds ago". A refresh reset it to the real mtime, since the file on disk was never touched.
Cause: the
Doc_ModifiedStatuspost-message handler updated the UI's mtime wheneverargs.Modified !== this.modified, which fires on bothfalse → true(doc becomes dirty) andtrue → false(saved). For presentations, Collabora emitsModified: trueshortly after open, triggering a spurious mtime bump.Fix: only call
FilesAppIntegration.updateFileInfoon thetrue → falsetransition, matching the original intent of the handler ("Update file metadata after save", f227260).Checklist